Re: Replace XChar2b with unsigned in all font backends

[Eli Zaretskii]

On May 21, 2019 12:50:59 PM GMT+01:00, Andy Moreton <address@hidden> wrote:
> On Tue 21 May 2019, Eli Zaretskii wrote:
> 
> > We are miscommunicating, I think. I didn't mean the problem
> shouldn't be
> > resolved ASAP, I meant it should be resolved by fixing the fallout
> from that
> > commit rather then by reverting it.
> 
> Indeed - the end goal is useful, but it seems we have different views
> on
> how to get there. This patch has problems on Windows (described in
> this
> thread), and on Linux (bug 35814).
> 
> Trying to fix it up in place will leave master broken for some time,
> so
> I think an initial revert followed by reworking the patch in smaller
> steps may be an easier way forward.
> 
>     AndyM

 Indeed, I think that reverting is a destructive and generally less efficient 
way of fixing the problem when the changeset in question is mostly correct.