[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Replace trivial pcase occurrences in the Emacs sources
From: |
Eli Zaretskii |
Subject: |
Re: Replace trivial pcase occurrences in the Emacs sources |
Date: |
Thu, 01 Nov 2018 06:15:51 +0200 |
> From: Michael Heerdegen <address@hidden>
> Cc: address@hidden, address@hidden
> Date: Wed, 31 Oct 2018 21:31:55 +0100
>
> > Not sure I follow: fixing _all_ of them will be _less_ work for you?
>
> I mean less work in summa.
>
> > I'm okay with only fixing pcase usage at this time, if you feel that
> > would be enough for one changeset.
>
> It would be ok for me to do both at once if that's also ok for you.
It's fine.
> > Really? Can you show a few examples? Maybe there's something wrong
> > with our documentation if people make such mistakes.
>
> Here is the result of a quick search. As Stefan said, I don't say we
> should fix (all of) these. But some really look strange. There are
> many quoted strings - I wonder if these quotes change the behavior of
> the compiler or so? I tiny fraction of the matches may be cases where
> the quote is significant, e.g. when located in a quoted structure, like
> in '('1).
I agree that we should fix those. I'm surprised we have so many of
them.
Thanks.
- Re: Replace trivial pcase occurrences in the Emacs sources, (continued)
- Re: Replace trivial pcase occurrences in the Emacs sources, Garreau\, Alexandre, 2018/11/01
- Re: Replace trivial pcase occurrences in the Emacs sources, Eli Zaretskii, 2018/11/01
- Re: Replace trivial pcase occurrences in the Emacs sources, Garreau\, Alexandre, 2018/11/01
- Re: Replace trivial pcase occurrences in the Emacs sources, Eli Zaretskii, 2018/11/01
- Re: Replace trivial pcase occurrences in the Emacs sources, TEIRLLM, 2018/11/01
- Re: Replace trivial pcase occurrences in the Emacs sources, Richard Stallman, 2018/11/02
- Re: Replace trivial pcase occurrences in the Emacs sources, Nix, 2018/11/04
- Re: Replace trivial pcase occurrences in the Emacs sources, Garreau\, Alexandre, 2018/11/04
- Re: Replace trivial pcase occurrences in the Emacs sources, TEIRLLM, 2018/11/01
Re: Replace trivial pcase occurrences in the Emacs sources, Eli Zaretskii, 2018/11/01
Re: Replace trivial pcase occurrences in the Emacs sources,
Eli Zaretskii <=
Re: Replace trivial pcase occurrences in the Emacs sources, Achim Gratz, 2018/11/01
Re: Replace trivial pcase occurrences in the Emacs sources, Stefan Monnier, 2018/11/01