emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: bignum branch


From: Andy Moreton
Subject: Re: bignum branch
Date: Tue, 07 Aug 2018 12:22:21 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (windows-nt)

On Mon 06 Aug 2018, Tom Tromey wrote:

>>>>>> "Paul" == Paul Eggert <address@hidden> writes:
>
> Paul> Tom Tromey wrote:
>>> So, if Eli or Paul can let me know what they want, I can do it.
>
> Paul> I prefer consistent names in the new version, even if they don't match
> Paul> the old names. I suggest C names like INTEGERP, XINTEGER, FIXNUMP,
> Paul> XFIXNUM, BIGNUMP, and XBIGNUM, where 'integer' is the disjoint union
> Paul> of 'fixnum' and 'bignum'. Although this consistency will cost us a bit
> Paul> in the short run (due to renaming) and even in the long run (due to
> Paul> 'git diff' output being longer), it's worth it to keep the code
> Paul> readable.
>
> Seems reasonable to me.  The branch is partway there already (as noted);
> but maybe all that's left is to rename XINT and XFASTINT.  So, XFIXNUM
> and XFASTFIXNUM?

XFASTINT should be XFIXNAT, as the matching predicate is FIXNATP.

    AndyM




reply via email to

[Prev in Thread] Current Thread [Next in Thread]