Re: [Emacs-diffs] emacs-25 a9c48d5: Additional fixes for file notification

[Stefan Monnier]

> As for concise...  sure, in characters.  But not in meaning.  If I'm
> reading code, I'm reading "if that is bigger than... zero!" instead of

Just write it (> 0 x) so you don't have to "..." until the punchline.

> immediately getting that it's a check for positivity.

As mentioned, I never remember which kind of "positivity" is used where,
whereas (> 0 x) and (>= 0 x) are 100% unambiguous.

> (The same logic for `zerop', by the way.)

I find (= 0 x) to work just as well, but at least `zerop' doesn't suffer
from plusp's ambiguity, so I'm OK with zerop (tho after having had to
work to make it as efficient as (= 0 x), I started to stay away from
it).


        Stefan