emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Emacs-diffs] emacs-25 a9c48d5: Additional fixes for file notificati


From: Clément Pit--Claudel
Subject: Re: [Emacs-diffs] emacs-25 a9c48d5: Additional fixes for file notification
Date: Tue, 23 Feb 2016 23:08:36 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1

On 02/23/2016 09:17 PM, Lars Ingebrigtsen wrote:
> Uhm...  that was all I was able to think of.  :-)  incf and plusp are
> the ones I find myself typing most often.

I'd love to see evenp and oddp used more often :)
I think (evenp x) reads much better that (eq (logand x 1) 0). Some examples 
from the code:

calendar/todo-mode.el:3507:15   : (strlen-odd (eq (logand strlen 1) 1))
calculator.el:1658:13           : ((eq (logand (truncate y) 1) 1)   ; expansion 
of cl `oddp'
progmodes/ruby-mode.el:1550:6   : (eq (logand (skip-chars-backward "\\") 1)
progmodes/elisp-mode.el:1462:43 : (> index 1) (eq (logand index 1) 1)))
erc/erc.el:6673:9               : (when (eq (logand (length args) 1) 1) ; oddp
play/hanoi.el:273:20            : (if (eq (logand n 1) 1)  ; oddp would require 
cl at runtime
hexl.el:1011:11                 : (if (eq (logand len 1) 1)

Cheers,
Clément.

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]