Re: Asynchronous DNS

[Alain Schneble]

Lars Ingebrigtsen <address@hidden> writes:

> But it would be nice if somebody could do a code review before merging
> to master.  Should I just post the diff here?  It's rather large, but
> mainly because many humongous functions have been split up into smaller,
> but still too-large, functions...

FWIW, I just wanted to say that I will for sure review the changes at
least to enhance my personal knowledge in that area.  But as I do not
yet have any expertise in "GNU Emacs core", this might be of very little
value for you.  So you for sure won't trust me as a reviewer and I think
you shouldn't either, really.  But anyway, I'm trying to get into it for
the future... ;)

BTW, I'll try to make at least set-process-coding-system non-blocking as
an exercise.  If that won't be patched by somebody else in the meantime,
I'll be happy to supply a patch for it in case I really succeed.  But
that could be applied to master after having merged the async-dns branch
back to master.

For me, posting a separate patch of all the changes from the async-dns
branch isn't needed.  It's so easy to follow the changes in the branch
directly.