[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: package-install-from-buffer moves point
From: |
Artur Malabarba |
Subject: |
Re: package-install-from-buffer moves point |
Date: |
Sun, 19 Jul 2015 18:06:26 +0100 |
>> This is due to calls to some `lm-*' functions inside
>> `package-buffer-info' (possibly one of the calls I added myself
>> yesterday). I can just wrap those in save-excursions, but I'm thinking
>> that the `lm-*' functions themselves should not be moving the point.
>> Shall I use save-excursion inside those functions instead?
>
> Well, there is also a goto-char call right at the top of
> package-buffer-info.
Clearly I should stop replying to messages on my phone where I can't
look at the code first. :)
> But I agree that the lm-* functions should
> probably save the point themselves, too. There are some calls to
> save-excursion in lisp-mnt.el, but it seems it's not applied consistently.
Yes. `lm-header' always moves point to the header (besides returning
it). All the others I looked through seem to be fine.