Re: [Emacs-diffs] master 3431e82: Ignore directory symlinks in directory-files-recursively

[Lars Magne Ingebrigtsen]

Stefan Monnier <address@hidden> writes:

>>     Ignore directory symlinks in directory-files-recursively
>
> Could you work on merging file-tree-walk and
> directory-files-recursively?

As you pointed out, `file-tree-walk' has the nice property that it can
stop recursing based on a predicate, so implementing it on
`directory-files-recursively' would not be optimal.

On the other hand, the interface for `file-tree-walk' is not what people
usually want -- they just want a list of matching files.  I grepped for
"defun.*recurs" and there's a lot of functions basically implementing
`directory-files-recursively'.  Here are the first four:

cedet-files-list-recursively
find-lisp-find-files
gnus-recursive-directory-files
nnfolder-recursive-directory-files

Doing it the other way around would almost be possible, but
`directory-files-recursively' guarantees that leaves are returned before
directories so that implementing "rm -r" is just a `mapc' over the
returned values.  And `file-tree-walk' doesn't call the callback
function in that order, so it's fiddly.

Besides, we don't have copyright paperwork for `file-tree-walk'.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no