[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [elpa] 01/03: [gnugo frolic int] Regularize keymap decl + init.
From: |
Thien-Thi Nguyen |
Subject: |
Re: [elpa] 01/03: [gnugo frolic int] Regularize keymap decl + init. |
Date: |
Wed, 09 Apr 2014 20:57:06 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) |
() Stefan Monnier <address@hidden>
() Wed, 09 Apr 2014 09:45:48 -0400
> +(unless gnugo-frolic-mode-map
> + (setq gnugo-frolic-mode-map (make-sparse-keymap))
> + [...])
Any reason not to use the standard
(defvar gnugo-frolic-mode-map
(let ((map (make-sparse-keymap)))
[...]
map))
Or even using pcase-dolist:
(defvar gnugo-frolic-mode-map
(let ((map (make-sparse-keymap)))
(suppress-keymap map)
(pcase-dolist [...])
map))
Well, the latter is still scary to this pre-‘dolist’-w/o-cl.el dinosaur,
although it certainly looks sveltely attractive (modulo backticks, but i
suppose they are unavoidable for ‘pcase’).
More disturbing is seeing a huge form early in the file, w/ many forward
references; i prefer to maintain top-level forms topo-sorted as much as
possible (surely a sign of C/Scheme braindamage -- call a doctor!).
But anyway, i'll stew on it for a while; thanks for the suggestion.
--
Thien-Thi Nguyen
GPG key: 4C807502
(if you're human and you know it)
read my lisp: (responsep (questions 'technical)
(not (via 'mailing-list)))
=> nil
pgpgAPz2PtX5h.pgp
Description: PGP signature