Re: [elpa] 01/03: [gnugo frolic int] Regularize keymap decl + init.

[Stefan Monnier]

> +(unless gnugo-frolic-mode-map
> +  (setq gnugo-frolic-mode-map (make-sparse-keymap))
> +  (suppress-keymap gnugo-frolic-mode-map)
> +  (mapc (lambda (pair)
> +          (define-key gnugo-frolic-mode-map (car pair) (cdr pair)))
> +        '(("q"          . gnugo-frolic-quit)
> +          ("C"          . gnugo-frolic-quit) ; like ‘View-kill-and-leave’
> +          ("\C-b"       . gnugo-frolic-backward-branch)
> +          ("\C-f"       . gnugo-frolic-forward-branch)
> +          ("j"          . gnugo-frolic-exchange-left)
> +          ("J"          . gnugo-frolic-rotate-left)
> +          ("k"          . gnugo-frolic-exchange-right)
> +          ("K"          . gnugo-frolic-rotate-right)
> +          ("\C-m"       . gnugo-frolic-set-as-main-line)
> +          ("\C-\M-p"    . gnugo-frolic-prune-branch)
> +          ("o"          . gnugo-frolic-return-to-origin))))
 
Any reason not to use the standard

   (defvar gnugo-frolic-mode-map
     (let ((map (make-sparse-keymap)))
       (suppress-keymap map)
       (mapc (lambda (pair)
               (define-key map (car pair) (cdr pair)))
             '(("q"          . gnugo-frolic-quit)
               ("C"          . gnugo-frolic-quit) ; like ‘View-kill-and-leave’
               ("\C-b"       . gnugo-frolic-backward-branch)
               ("\C-f"       . gnugo-frolic-forward-branch)
               ("j"          . gnugo-frolic-exchange-left)
               ("J"          . gnugo-frolic-rotate-left)
               ("k"          . gnugo-frolic-exchange-right)
               ("K"          . gnugo-frolic-rotate-right)
               ("\C-m"       . gnugo-frolic-set-as-main-line)
               ("\C-\M-p"    . gnugo-frolic-prune-branch)
               ("o"          . gnugo-frolic-return-to-origin)))
       map))

Or even using pcase-dolist:

   (defvar gnugo-frolic-mode-map
     (let ((map (make-sparse-keymap)))
       (suppress-keymap map)
       (pcase-dolist (`(,key . ,cmd)
                      '(("q"          . gnugo-frolic-quit)
                        ("C"          . gnugo-frolic-quit) ; like 
‘View-kill-and-leave’
                        ("\C-b"       . gnugo-frolic-backward-branch)
                        ("\C-f"       . gnugo-frolic-forward-branch)
                        ("j"          . gnugo-frolic-exchange-left)
                        ("J"          . gnugo-frolic-rotate-left)
                        ("k"          . gnugo-frolic-exchange-right)
                        ("K"          . gnugo-frolic-rotate-right)
                        ("\C-m"       . gnugo-frolic-set-as-main-line)
                        ("\C-\M-p"    . gnugo-frolic-prune-branch)
                        ("o"          . gnugo-frolic-return-to-origin))
         (define-key map key cmd)))
       map))


-- Stefan