[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: changes to cfengine-mode
From: |
Ted Zlatanov |
Subject: |
Re: changes to cfengine-mode |
Date: |
Wed, 21 Dec 2011 06:31:23 -0500 |
User-agent: |
Gnus/5.110018 (No Gnus v0.18) Emacs/24.0.90 (gnu/linux) |
On Fri, 16 Dec 2011 19:45:53 -0500 Stefan Monnier <address@hidden> wrote:
>> OK. See attached, and I hope final, patch.
SM> A few more nit picks, feel free to install the patch after addressing them.
Done. I left the Version header in; feel free to remove it if plans change.
SM> Why not merge the two entries into something like:
SM> (,(concat "\\<" cfengine3-defuns-regex "\\>"
SM> "[ \t]+\\<\\([[:alnum:]_]+\\)\\>"
SM> "[ \t]+\\<\\([[:alnum:]_]+\\)\\(?:(\\([^)]*\\))\\)?")
SM> (1 font-lock-builtin-face)
SM> (2 font-lock-constant-face)
SM> (3 font-lock-function-name-face)
SM> (4 font-lock-variable-name-face nil t))
I thought my version was easier to read, but I used yours with an extra
comment to explain the last part.
SM> And please make sure you explain in the commit log (or here in
SM> comments) why this code was moved to the beginning of
SM> cfengine3-font-lock-keywords.
OK, done in the comments.
Ted
- Re: prog-mode not available in earlier Emacsen, need help with cfengine.el, Ted Zlatanov, 2011/12/01
- changes to cfengine-mode (was: prog-mode not available in earlier Emacsen, need help with cfengine.el), Ted Zlatanov, 2011/12/02
- Re: changes to cfengine-mode, Stefan Monnier, 2011/12/02
- Re: changes to cfengine-mode, Ted Zlatanov, 2011/12/07
- Re: changes to cfengine-mode, Stefan Monnier, 2011/12/07
- Re: changes to cfengine-mode, Chong Yidong, 2011/12/08
- Re: changes to cfengine-mode, Ted Zlatanov, 2011/12/13
- Re: changes to cfengine-mode, Stefan Monnier, 2011/12/13
- Re: changes to cfengine-mode, Ted Zlatanov, 2011/12/13
- Re: changes to cfengine-mode, Stefan Monnier, 2011/12/16
- Re: changes to cfengine-mode,
Ted Zlatanov <=
- Re: changes to cfengine-mode, Ted Zlatanov, 2011/12/13
- Re: changes to cfengine-mode, Stefan Monnier, 2011/12/07
- Re: changes to cfengine-mode, Ted Zlatanov, 2011/12/13