[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] [NS] Fix compilation with clang on OSX
From: |
Adrian Robert |
Subject: |
Re: [PATCH] [NS] Fix compilation with clang on OSX |
Date: |
Fri, 5 Nov 2010 10:32:45 +0200 |
On 2010/11/05, at 2:04, Glenn Morris wrote:
> 1) Put both your names as the author (and mark with "tiny change" in
> this case).
Like this?
> 2010-11-04 Adrian Robert <address@hidden>
> 2010-11-04 Ismail Donmez <address@hidden> (tiny change)
>
> * nsfont.m (nsfont_draw)
> * nsimage.m (EmacsImage-setXBMColor:)
> * nsterm.m (EmacsView-performDragOperation:): Correct empty return
> statements.
It seems to be more ambiguous than putting one "communicating author" and an
attribution.
> 2) Make the original change in his name (marked "tiny change"); then
> apply your correction as a separate change.
Like this:
> 2010-11-04 Adrian Robert <address@hidden>
>
> * nsfont.m (nsfont_draw): Correct previous patch to return
> correct value.
> * nsimage.m (EmacsImage-setXBMColor:): Correct previous patch:
> don't change the method signature, change the return.
>
> 2010-11-04 Ismail Donmez <address@hidden> (tiny change)
>
> * nsfont.m (nsfont_draw)
> * nsimage.m (EmacsImage-setXBMColor:)
> * nsterm.m (EmacsView-performDragOperation:): Correct empty return.
If people would really prefer this I can do it in the future. (Or hassle the
patch submitter to redo their patch, I suppose.) The reason I haven't before
is when you are dealing with a "tiny change" in the first place, going into
this kind of detail seems excessive.
-Adrian