[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] [NS] Fix compilation with clang on OSX
|
From: |
İsmail Dönmez |
|
Subject: |
Re: [PATCH] [NS] Fix compilation with clang on OSX |
|
Date: |
Thu, 4 Nov 2010 20:00:03 +0200 |
Hi;
On Thu, Nov 4, 2010 at 7:52 PM, David Reitter <address@hidden> wrote:
>
> On Nov 4, 2010, at 12:15 PM, İsmail Dönmez wrote:
> > Attached is a patch fixing emacs compilation with clang on OSX. Just some
> > minor problems.
>
> These are good, even for the non-clang compilation case.
Indeed!
> In nsfont_draw(), don't you want to return (to-from) rather than 0?
Currently it just returns which is equivalent to 0 in gcc case, so I
didn't want to change that.
> Have you obtained significant performance benefits from compiling with clang?
Compilation is faster, warning diagnostics are better, speed wise it
seems equal to my eyes :)
Regards,
ismail