[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
improve vc-bzr-print-log
From: |
Dan Nicolaescu |
Subject: |
improve vc-bzr-print-log |
Date: |
Sun, 26 Jul 2009 10:28:23 -0700 (PDT) |
When vc-bzr was written "bzr log" did not take multiple file arguments,
it does now, so vc-bzr-print-log can take advantage of this.
Any objection to this patch?
--- vc-bzr.el.~1.78.~ 2009-05-25 20:57:29.000000000 -0700
+++ vc-bzr.el 2009-07-26 10:25:30.000000000 -0700
@@ -457,7 +457,7 @@ REV non-nil gets an error."
(remove-hook 'log-view-mode-hook 'vc-bzr-log-view-mode) ;Deactivate the hack.
(require 'add-log)
(set (make-local-variable 'log-view-per-file-logs) nil)
- (set (make-local-variable 'log-view-file-re) "^Working file:[ \t]+\\(.+\\)")
+ (set (make-local-variable 'log-view-file-re) "\\`a\\`")
(set (make-local-variable 'log-view-message-re)
"^ *\\(?:revno: \\([0-9.]+\\)\\|merged: .+\\)")
(set (make-local-variable 'log-view-font-lock-keywords)
@@ -481,16 +481,11 @@ REV non-nil gets an error."
;; FIXME: `vc-bzr-command' runs `bzr log' with `LC_MESSAGES=C', so
;; the log display may not what the user wants - but I see no other
;; way of getting the above regexps working.
- (dolist (file files)
- (vc-exec-after
- `(let ((inhibit-read-only t))
- (with-current-buffer buffer
- ;; Insert the file name so that log-view.el can find it.
- (insert "Working file: " ',file "\n")) ;; Like RCS/CVS.
- (apply 'vc-bzr-command "log" ',buffer 'async ',file
- ',(if (stringp vc-bzr-log-switches)
- (list vc-bzr-log-switches)
- vc-bzr-log-switches))))))
+ (with-current-buffer buffer
+ (apply 'vc-bzr-command "log" buffer 'async files
+ (if (stringp vc-bzr-log-switches)
+ (list vc-bzr-log-switches)
+ vc-bzr-log-switches))))
(defun vc-bzr-show-log-entry (revision)
"Find entry for patch name REVISION in bzr change log buffer."
- improve vc-bzr-print-log,
Dan Nicolaescu <=