Re: Things I would like to be added after the release

[joakim]

Stefan Monnier <address@hidden> writes:

>> 0)   ECB works fine as is with advice.
>> 3) By observing what extension points ECB needed, what
>>      hooks/extension points can base Emacs provide? What can we
>>      learn?  Which of the ECB extension points are ECB specific,
>>      and which aren't? 
>
> That's exactly what is usually meant by "don't use advice in Emacs".
> Basically any use of defadvice is either an indication that the programmer
> didn't know about some other way to do the thing, or an indication that
> there is a missing hook (or config/extension point).
>
> But it can be difficult for Emacs authors to study some external library to
> try and understand what hook/extension would be desired.  So it's a lot
> better if the library's maintainer helps us coming up with the right
> extension point.
>
>
>         Stefan

I did a quick grep on defadvice on ECB below.
Disclaimer: I'm not involved in ECB development, other than as a user.



./ecb-eshell.el:141:(defadvice eshell (around ecb)
./ecb-create-layout.el:237:(defadvice delete-frame (before ecb-create-layout)
./ecb-create-layout.el:246:(defadvice delete-frame (after ecb-create-layout)
./ecb-compatibility.el:63:(defadvice bs-show (before ecb)
./ecb-compatibility.el:77:(defadvice Electric-pop-up-window (around ecb)
./ecb-compatibility.el:95:(defadvice electric-command-history (before ecb)
./ecb-compatibility.el:102:(defadvice electric-buffer-list (before ecb)
./ecb-compatibility.el:109:(defadvice electric-buffer-list (after ecb)
./ecb.texi:10792:(defadvice vc-checkin (after ecb)
./ecb.texi:13885:(defadvice XXX (before ecb activate)
./ecb-winman-support.el:177:(defadvice 
escreen-save-current-screen-configuration (before ecb)
./ecb-winman-support.el:227:(defadvice winring-set-name (after ecb)
./ecb-winman-support.el:245:(defadvice winring-duplicate-configuration (before 
ecb)
./ecb-winman-support.el:250:(defadvice winring-restore-configuration (before 
ecb)
./ecb-winman-support.el:259:(defadvice winring-save-current-configuration 
(before ecb)
./ecb-winman-support.el:270:(defadvice winring-initialize (after ecb)
./ecb-winman-support.el:293:(defadvice winner-mode (before ecb)
./ecb-winman-support.el:298:(defadvice winner-redo (before ecb)
./ecb-winman-support.el:303:(defadvice winner-undo (before ecb)
./ecb-winman-support.el:309:  (defadvice push-window-configuration (before ecb)
./ecb-winman-support.el:314:  (defadvice pop-window-configuration (before ecb)
./ecb-winman-support.el:319:  (defadvice unpop-window-configuration (before ecb)
./ecb.info-2:2659:        (defadvice vc-checkin (after ecb)
./ecb.info-2:4743:   (defadvice XXX (before ecb activate)
./ecb-speedbar.el:118:(defadvice speedbar-click (around ecb)
./ecb-speedbar.el:141:(defadvice speedbar-frame-mode (around ecb)
./ecb-speedbar.el:149:(defadvice speedbar-get-focus (around ecb)
./ecb-speedbar.el:163:(defadvice dframe-mouse-set-point (around ecb)
./ecb-speedbar.el:184:(defadvice dframe-select-attached-frame (after ecb)
./ecb-util.el:413:(defadvice custom-save-all (around ecb)
./ecb-layout.el:1356:(defadvice delete-frame (around ecb)
./ecb-layout.el:1381:(defadvice compilation-set-window-height (around ecb)
./ecb-layout.el:1432:(defadvice scroll-other-window (around ecb)
./ecb-layout.el:1469:(defadvice scroll-all-mode (after ecb)
./ecb-layout.el:1481:(defadvice count-windows (around ecb)
./ecb-layout.el:1497:(defadvice walk-windows (around ecb)
./ecb-layout.el:1522:(defadvice one-window-p (around ecb)
./ecb-layout.el:1538:;; (defadvice find-file (around ecb)
./ecb-layout.el:1553:;; (defadvice find-file-other-window (around ecb)
./ecb-layout.el:1617: (defadvice show-temp-buffer-in-current-frame (around ecb)
./ecb-layout.el:1657: (defadvice shrink-window-if-larger-than-buffer (around 
ecb)
./ecb-layout.el:1740: (defadvice pop-to-buffer (around ecb)
./ecb-layout.el:1754: (defadvice mouse-drag-vertical-line (around ecb)
./ecb-layout.el:1765: (defadvice mouse-drag-mode-line (around ecb)
./ecb-layout.el:1777: (defadvice enlarge-window (around ecb)
./ecb-layout.el:1788: (defadvice shrink-window (around ecb)
./ecb-layout.el:1794:            ;; See comment of defadvice for 
mouse-drag-mode-line
./ecb-layout.el:1804: (defadvice tmm-prompt (around ecb)
./ecb-layout.el:1826: (defadvice shrink-window-if-larger-than-buffer (around 
ecb)
./ecb-layout.el:1867: (defadvice resize-temp-buffer-window (around ecb)
./ecb-layout.el:1909: (defadvice pop-to-buffer (around ecb)
./ecb-layout.el:2796:(defadvice display-buffer (around ecb)
./ecb-layout.el:3182:(defadvice other-window (around ecb)
./ecb-layout.el:3198:(defadvice delete-windows-on (around ecb)
./ecb-layout.el:3274:(defadvice delete-window (before ecb)
./ecb-layout.el:3303:(defadvice delete-window (around ecb)
./ecb-layout.el:3365:(defadvice delete-other-windows (before ecb)
./ecb-layout.el:3389:(defadvice delete-other-windows (around ecb)
./ecb-layout.el:3453:(defadvice split-window-horizontally (around ecb)
./ecb-layout.el:3474:(defadvice split-window-vertically (around ecb)
./ecb-layout.el:3493:(defadvice split-window (before ecb)
./ecb-layout.el:3520:(defadvice split-window (around ecb)
./ecb-layout.el:3557:(defadvice switch-to-buffer-other-window (around ecb)
./ecb-layout.el:3598:(defadvice switch-to-buffer (around ecb)
./ecb-layout.el:3653:(defadvice other-window-for-scrolling (around ecb)
./ecb-layout.el:3681:(defadvice balance-windows (around ecb)
./ecb-layout.el:4516:(defadvice current-window-configuration (after ecb)
./ecb-layout.el:4551:(defadvice set-window-configuration (after ecb)
./ecb-file-browser.el:2826:(defadvice clearcase-sync-from-disk (after ecb)
./ecb-file-browser.el:3111:(defadvice vc-checkin (after ecb)


-- 
Joakim Verona