Re: Bug in change in button.el?

[Eli Zaretskii]

> From: Glenn Morris <address@hidden>
> Date: Mon, 23 Apr 2007 19:15:50 -0400
> Cc: address@hidden
> 
> Richard Stallman wrote:
> 
> >      ;; Use color for the MS-DOS port because it doesn't support underline.
> >     -(defface button '((((type pc) (class color))
> >     +;; Also for the linux console.
> >     +(defface button '((((type pc tty) (class color))
> >
> > Doesn't "tty" include xterms?  If so, it will give the wrong results
> > on xterms that can underline.
> 
> Nick already changed it, for this very reason I think.

Actually, I think we should not have touched this at all.  Face
definitions are frail; it took us a long time during development to
get to the current consensus.  It's beyond me why Nick, who was afraid
of Miles tweaking CVS comments, went ahead and made a much more
sensitive change.