emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Bug in change in button.el?


From: Nick Roberts
Subject: Re: Bug in change in button.el?
Date: Wed, 25 Apr 2007 10:22:15 +1200

 > > Do you mean the change to inherit from `link'?
 > > I thought we did not want buttons to look just like links.
 > > Also, what the definition of `link' does is use color and underlining
 > > together, although each one of them works only when supported.
 > 
 > Then I guess this change is better. The (type pc) test can be removed
 > if MS-DOS correctly answers the (supports) question.

But this seems a bit tortuous.  If we want to do this, button might as well
just inherit from the underline face.

 > *** button.el        23 Apr 2007 03:32:12 -0000      1.27
 > --- button.el        24 Apr 2007 22:00:18 -0000
 > ***************
 > *** 52,62 ****
 >   ;; Globals
 >   
 >   ;; Use color for the MS-DOS port because it doesn't support underline.
 > - ;; Also for the linux console.
 >   (defface button '((((type pc) (class color))
 >                 (:foreground "lightblue"))
 > !              (((type tty)) (:inherit link))
 > !              (t :underline t))
 >     "Default face used for buttons."
 >     :group 'basic-faces)
 >   
 > --- 52,61 ----
 >   ;; Globals
 >   
 >   ;; Use color for the MS-DOS port because it doesn't support underline.
 >   (defface button '((((type pc) (class color))
 >                 (:foreground "lightblue"))
 > !              (((supports :underline t)) :underline t)
 > !              (t (:foreground "lightblue")))
 >     "Default face used for buttons."
 >     :group 'basic-faces)
 >   
 > 
 > 
 > 
 > _______________________________________________
 > Emacs-devel mailing list
 > address@hidden
 > http://lists.gnu.org/mailman/listinfo/emacs-devel

-- 
Nick                                           http://www.inet.net.nz/~nickrob




reply via email to

[Prev in Thread] Current Thread [Next in Thread]