Re: Possible redisplay performance enhancements (revisited)

[Eli Zaretskii]

> Date: Fri, 21 Apr 2006 18:47:40 +0900
> From: YAMAMOTO Mitsuharu <address@hidden>
> 
>   2. Need to check face_id < BASIC_FACE_ID_SENTINEL in 
> get_*_face_and_encoding?
>      http://lists.gnu.org/archive/html/emacs-devel/2006-02/msg00238.html
> 
>      No response, but I couldn't find any reason to distinguish 
>      known faces from others with respect to encode_char.

I think it doesn't want to assume single-byte for unknown faces, but
I'm not sure if this is really needed.

Handa-san, could you please comment on the suggested patch (below)?

> Index: src/xdisp.c
> ===================================================================
> RCS file: /cvsroot/emacs/emacs/src/xdisp.c,v
> retrieving revision 1.1089
> diff -c -r1.1089 xdisp.c
> *** src/xdisp.c       20 Apr 2006 23:03:03 -0000      1.1089
> --- src/xdisp.c       21 Apr 2006 08:47:17 -0000
> ***************
> *** 18495,18502 ****
>        sure to use a face suitable for unibyte.  */
>         STORE_XCHAR2B (char2b, 0, glyph->u.ch);
>       }
> !   else if (glyph->u.ch < 128
> !        && glyph->face_id < BASIC_FACE_ID_SENTINEL)
>       {
>         /* Case of ASCII in a face known to fit ASCII.  */
>         STORE_XCHAR2B (char2b, 0, glyph->u.ch);
> --- 18495,18501 ----
>        sure to use a face suitable for unibyte.  */
>         STORE_XCHAR2B (char2b, 0, glyph->u.ch);
>       }
> !   else if (glyph->u.ch < 128)
>       {
>         /* Case of ASCII in a face known to fit ASCII.  */
>         STORE_XCHAR2B (char2b, 0, glyph->u.ch);
> ***************
> *** 18897,18903 ****
>         face_id = FACE_FOR_CHAR (f, face, c);
>         face = FACE_FROM_ID (f, face_id);
>       }
> !   else if (c < 128 && face_id < BASIC_FACE_ID_SENTINEL)
>       {
>         /* Case of ASCII in a face known to fit ASCII.  */
>         STORE_XCHAR2B (char2b, 0, c);
> --- 18896,18902 ----
>         face_id = FACE_FOR_CHAR (f, face, c);
>         face = FACE_FROM_ID (f, face_id);
>       }
> !   else if (c < 128)
>       {
>         /* Case of ASCII in a face known to fit ASCII.  */
>         STORE_XCHAR2B (char2b, 0, c);
> 
> 
> _______________________________________________
> Emacs-devel mailing list
> address@hidden
> http://lists.gnu.org/mailman/listinfo/emacs-devel
>