[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Crash on loading image
From: |
François Pinard |
Subject: |
Re: Crash on loading image |
Date: |
14 Feb 2002 21:14:29 -0500 |
User-agent: |
Gnus/5.09 (Gnus v5.9.0) Emacs/21.1.90 |
[Pavel Janík]
> can you please test this? I will provide ChangeLog entry later.
> Too tired right now...
> --- xfns.c.~1.537.~ Tue Jan 22 16:16:44 2002
> +++ xfns.c Wed Feb 6 15:49:29 2002
> @@ -10161,8 +10161,8 @@
> return 0;
> }
>
> - width = img->width = gif->SWidth;
> - height = img->height = gif->SHeight;
> + width = img->width = max (gif->SWidth, gif->Image.Left + gif->Image.Width);
> + height = img->height = max(gif->SHeight, gif->Image.Top +
> gif->Image.Height);
>
> /* Create the X image and pixmap. */
> if (!x_create_x_image_and_pixmap (f, width, height, 0, &ximg,
> &img->pixmap))
Pavel, I just installed 21.1.90 without the patch above, and Emacs vanishes
whenever I open any of the two images you provided in your reply. I then
installed the said patch over 21.1.90, and the image is now opened correctly
in both cases. So the patch does repair something :-). Congratulations!
I'm merely repeating the remainder of your comments for the other readers:
> This will be needed in RC and in HEAD. I'm CCing emacs-devel because
> we need to get more testing for this. If you would like to know why to
> test this, just try the above recipe with attached pictures. I have
> tested this on a package of about 1400 pictures and only one of them
> (attached opensign.gif) had the same problem (we used Screen Width of GIF,
> but it was to small) and thus we crashed.
--
François Pinard http://www.iro.umontreal.ca/~pinard
- Re: Crash on loading image, Pavel Janík, 2002/02/06
- Re: Crash on loading image,
François Pinard <=
- Re: Crash on loading image, Pavel Janík, 2002/02/16
- Re: Crash on loading image, Eli Zaretskii, 2002/02/17
- Re: Crash on loading image, François Pinard, 2002/02/17
- Re: Crash on loading image, Pavel Janík, 2002/02/20
- Re: Crash on loading image, François Pinard, 2002/02/20
- Re: Crash on loading image, Jason Rumney, 2002/02/21
- Re: Crash on loading image, Pavel Janík, 2002/02/23
- Re: Crash on loading image, Jason Rumney, 2002/02/23
- Re: Crash on loading image, Richard Stallman, 2002/02/22
- Re: Crash on loading image, Pavel Janík, 2002/02/23