|Subject:||Re: [Duplicity-talk] Fwd: AssertionError on every attempt|
|Date:||Wed, 10 Jun 2015 01:36:28 +1000|
On 9 June 2015 at 17:22, Rupert Levene <address@hidden> wrote:
> _delete removes one file at a time, but there can be any number of
> files with the same name and we need to remove them all.
> The loop will terminate when all the files are deleted since an
> exception will be raised in id_by_name.
The except: is not great practice, since it'll silence any more
serious error. Rather check which exception gets thrown when the file
isn't present and only catch that.
I haven't dug into the code at all, but it also scares me that the
manifest file can end up with the same volume number listed twice.
Presumably the manifest code is all backend-neutral, which makes me
wonder if there is a separate issue causing that to happen?
|[Prev in Thread]||Current Thread||[Next in Thread]|