duplicity-talk
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Duplicity-talk] Fwd: AssertionError on every attempt


From: edgar . soldin
Subject: Re: [Duplicity-talk] Fwd: AssertionError on every attempt
Date: Tue, 09 Jun 2015 18:04:01 +0200
User-agent: Mozilla/5.0 (Windows NT 5.1; rv:31.0) Gecko/20100101 Thunderbird/31.7.0

On 09.06.2015 17:36, Scott McKenzie wrote:
> 
> On 10 June 2015 at 01:28, Bruce Merry <address@hidden 
> <mailto:address@hidden>> wrote:
> 
>     On 9 June 2015 at 17:22, Rupert Levene <address@hidden 
> <mailto:address@hidden>> wrote:
>     > _delete removes one file at a time, but there can be any number of
>     > files with the same name and we need to remove them all.
>     >
>     > The loop will terminate when all the files are deleted since an
>     > exception will be raised in id_by_name.
> 
>     The except: is not great practice, since it'll silence any more
>     serious error. Rather check which exception gets thrown when the file
>     isn't present and only catch that.
> 
>     I haven't dug into the code at all, but it also scares me that the
>     manifest file can end up with the same volume number listed twice.
>     Presumably the manifest code is all backend-neutral, which makes me
>     wonder if there is a separate issue causing that to happen?
> 
>     Bruce
> 
> 
> I've had a quick look at the code and I think the _query method should be 
> modified to search for the filename.  It currently retrieves all files from 
> drive then iterates the list looking for the matching filename.  I suspect 
> that it is running in to a maximum list length returned from drive (even 
> though the pydrive docs say all files are returned).
> 

i couldn't find a place where the success of the upload is verified via a size 
retrieved afterwards. it merely looks like google drive stores files via a 
unique id and folder and file name are just metadata, hence every upload retry 
creates a new file instance afaics. also see my previous mail.

..ede/duply



reply via email to

[Prev in Thread] Current Thread [Next in Thread]