[Pnet-developers] [patch #3512] correct a off-by-one display bug in Graphics.DrawString

[Erich Kitzmüller]

This mail is an automated notification from the patch tracker
 of the project: DotGNU Portable.NET.

/**************************************************************************/
[patch #3512] Latest Modifications:

Changes by: 
                Erich Kitzmüller <address@hidden>
'Date: 
                Die 07.12.2004 at 11:58 (GMT)

------------------ Additional Follow-up Comments ----------------------------
I think it is simply caused by the "- 1" in line 1496-1497,
though I'm not sure what ConvertRectangle does:

// convert the layout into device coordinates
                Point[] rect = ConvertRectangle
                    ((layoutRectangle.X + baseWindow.X),
                     (layoutRectangle.Y + baseWindow.Y),
                     (layoutRectangle.Width - 1),
                     (layoutRectangle.Height - 1),
                     pageUnit);







/**************************************************************************/
[patch #3512] Full Item Snapshot:

URL: <http://savannah.gnu.org/patch/?func=detailitem&item_id=3512>
Project: DotGNU Portable.NET
Submitted by: Erich Kitzmüller
On: Mit 10.11.2004 at 12:58

Category:  None
Priority:  5 - Normal
Resolution:  Applied
Privacy:  Public
Assigned to:  None
Originator Email:  
Status:  Closed


Summary:  correct a off-by-one display bug in Graphics.DrawString

Original Submission:  Because of this bug, in MenuItems as well as in table 
Cells of SourceGridMini (yes, it works in portable.net) the last character of 
the String was not displayed.

Follow-up Comments
------------------


-------------------------------------------------------
Date: Die 07.12.2004 at 11:58       By: Erich Kitzmüller <ammoq>
I think it is simply caused by the "- 1" in line 1496-1497,
though I'm not sure what ConvertRectangle does:

// convert the layout into device coordinates
                Point[] rect = ConvertRectangle
                    ((layoutRectangle.X + baseWindow.X),
                     (layoutRectangle.Y + baseWindow.Y),
                     (layoutRectangle.Width - 1),
                     (layoutRectangle.Height - 1),
                     pageUnit);


-------------------------------------------------------
Date: Die 07.12.2004 at 11:30       By: Gopal.V <t3rmin4t0r>
Applied to CVS on 7th Dec 2004.

Apparently this is simply a workaround to fix the problem.
More investigation needs to be done to figure out the real
reason why it is one off.






File Attachments
-------------------

-------------------------------------------------------
Date: Mit 10.11.2004 at 12:58  Name: Graphics.cs.patch  Size: 481B   By: ammoq

http://savannah.gnu.org/patch/download.php?item_id=3512&amp;item_file_id=3868






For detailed info, follow this link:
<http://savannah.gnu.org/patch/?func=detailitem&item_id=3512>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/