Re: Crash on app start due to icon

[Wolfgang Lux]

Hi Riccardo,

> Of course it retains the "behaviour" of the grey Icon until launch completes.
> Interestingly, on Ubuntu I can actually dock an app and it will retain the 
> icon, on OpenBSD instead it WindowMaker will revert to generic.

on NetBSD 8 with WindowMaker 0.95.8 the icon isn't retained either.

> 
>>> 
>>> I wonder however now if the patch is corect, since Gregory changed 
>>> initialization order. I also wonder more about the behaviour we are having:
>>> 
>>> - app starts I see a grey icon bouncing in the WM dock
>>> . once completed, the icon appears
>> Is that a regression before Greg made his change or did you observe that 
>> issue before as well?
> 
> If I am not mistaken, it is not a regression, it is just something I noticed 
> (again) while looking at this.
> Does it happen for you? Some apps start quick so you don't notice, but on a 
> slower/loaded machine it is clear.

It's hard to notice for me. From the few applications I've tested, perhaps it 
was most obvious for batmon.app.
I think the problem is the hack I committed a few years back to fix the issue 
with the first application opened in WindowMaker not getting a proper 
application menu. The problem is that the app icon must be the first window 
that is created and mapped by the application for us to be able to set the 
application menu. To make that work, my fix creates the app icon window early 
on in -[XGServer _setupRootWindow]. In particular, it does that before the 
method tries to determine the size of the window borders by creating a set of 
(off-screen) windows. But since we don't know the app icon at the time when 
_setupRootWindow is called, this means that the app icon will remain blank 
(well, grey) until the icon gets set later. :-(

Wolfgang