Re: [Discuss-gnuradio] log2() missing in MSVC v16

[Tom Rondeau]

On Thu, Oct 23, 2014 at 8:26 AM, Martin Braun <address@hidden> wrote:

On 10/22/2014 03:16 PM, Gisle Vanem wrote:
> Well, volk now uses the log2() function which my MSVC v16
> doesn't have. And multiply_matrix_ff_impl.cc etc. uses these ISO-646
> "keywords" like 'not', 'and' etc. I solved these errors by patching
> cmake/msvc/config.h like so:

Tom patched the nots, ors and ands a while back, at least on master. So
you shouldn't have to take care of those.

Looks like a missed to 'not's in there :) I'll patch this soon.

 

> @@ -29,6 +29,16 @@
> static inline double rint(double x){return (x > 0.0)? floor(x + 0.5) :
> ceil(x - 0.5);}
> static inline float rintf(float x){return (x > 0.0f)? floorf(x + 0.5f) :
> ceilf(x - 0.5f);}
>
> +static inline double log2 (double x)
> +{
> +  return log ((double)x) / log (2.0F);
> +}

This might be useful, but I can't say. However, please make this an
issue on the issue tracker, or it'll get lost.

Cheers,

M

Also, considering that Windows XP is an unsupported operating system from Microsoft, we don't have much of an incentive to track it or keep things updated there. If your patches are trivial and don't bother anything else, then sure. But it looks like your patch here just shoves in the log2 without regard for whether or not log2 actually exists on the system. There's going to need to be a #if check around it. Perhaps Cmake can check for log2 and define a variable (HAVE_LOG2 or something) for this.

Tom