[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] split: plug a nominal leak
|
From: |
Pádraig Brady |
|
Subject: |
Re: [PATCH] split: plug a nominal leak |
|
Date: |
Sat, 04 Aug 2012 10:16:49 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:6.0) Gecko/20110816 Thunderbird/6.0 |
On 08/04/2012 10:12 AM, Jim Meyering wrote:
> Pádraig Brady wrote:
>> On 08/03/2012 01:53 PM, Jim Meyering wrote:
>>> I ran "make check" on valgrind-wrapped tools (took most of a day on a
>>> 6/12-core system) and saw split at the top of the list of "definitely lost
>>> buffer" leaks. So far, the only ones I've investigated are not important,
>>> but at least now, they are plugged and will not distract us further:
>>
>> Yes, these are only wasted cycles before exit().
>> I'd suggest wrapping in IF_LINT ();
>> as we do in df.c and sort.c
>
> Good point. Thanks for the reminder.
> I've also combined those two into a single commit:
Looks good,
cheers,
Pádraig.