coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] tests: avoid FP ulimit failure with valgrind-wrapped tools


From: Jim Meyering
Subject: [PATCH] tests: avoid FP ulimit failure with valgrind-wrapped tools
Date: Fri, 03 Aug 2012 16:36:45 +0200

All ulimit-requiring tests would be skipped
when running against valgrind-wrapped tools.
This adjusts the heuristic to avoid that:

>From 5367b398b0dc203e84e4210c647f4b03ed4dcfe2 Mon Sep 17 00:00:00 2001
From: Jim Meyering <address@hidden>
Date: Thu, 2 Aug 2012 19:12:18 +0200
Subject: [PATCH] tests: avoid FP ulimit failure with valgrind-wrapped tools

* tests/init.cfg (require_ulimit_): Raise VM limit from 10MiB to
20MiB, to accommodate overhead of a valgrind-wrapped date program.
---
 tests/init.cfg | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/tests/init.cfg b/tests/init.cfg
index c1cb92f..6c16fff 100644
--- a/tests/init.cfg
+++ b/tests/init.cfg
@@ -108,12 +108,13 @@ require_openat_support_()
 require_ulimit_()
 {
   ulimit_works=yes
-  # Expect to be able to exec a program in 10MB of virtual memory,
+  # Expect to be able to exec a program in 20MB of virtual memory,
+  # (10MB is usually plenty, but valgrind-wrapped date requires 1900KiB)
   # but not in 20KB.  I chose "date".  It must not be a shell built-in
   # function, so you can't use echo, printf, true, etc.
   # Of course, in coreutils, I could use $top_builddir/src/true,
   # but this should be able to work for other projects, too.
-  ( ulimit -v 10000; date ) > /dev/null 2>&1 || ulimit_works=no
+  ( ulimit -v 20000; date ) > /dev/null 2>&1 || ulimit_works=no
   ( ulimit -v 20;    date ) > /dev/null 2>&1 && ulimit_works=no

   test $ulimit_works = no \
--
1.7.12.rc1.10.g97c7934



reply via email to

[Prev in Thread] Current Thread [Next in Thread]