coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[coreutils] [PATCH] unexpand: support --in-place option


From: Sami Kerola
Subject: [coreutils] [PATCH] unexpand: support --in-place option
Date: Sun, 7 Nov 2010 21:17:20 +0100

I proposed in place editing support earlier (21 Mar 2009), but then
you could not accept the patch because (a) I had not done legal
paperwork (b) it was not awesome. Now legal matters should no longer
be issue, but quite frankly the point b could still be a problem.

Last time I got few instructions how the in place could be better. So
here is the new version, that uses conventions of other commands;
like SIMPLE_BACKUP_SUFFIX & VERSION_CONTROL. Even without making in
place working with fmt, fold, nl, tac, tr & expand the patch is
pretty large, and potentially causes flock of bugs.

There is also issue with permission bits when combined with backups.
To fix that copy.c requires some sort of, small or big, change, and I
don't feel good doing such before talking to maintainer first.

I am afraid Pádraig was right last time; '[...] On the other hand
it's simple enough to achieve this using existing commands'. How
about you, now when it's more visible what's required when in place
uses copy.c etc. Is it time to document this change to rejected ideas
area, and never propose this again? Or keep on hacking to this
direction?


 lib/in-place.c  |  340 +++++++++++++++++++++++++++++++++++++++++++++++++++++++
 lib/in-place.h  |   24 ++++
 m4/in-place.m4  |   18 +++
 m4/prereq.m4    |    1 +
 src/Makefile.am |    5 +
 src/cp.c        |   20 +---
 src/install.c   |   14 +--
 src/ln.c        |   19 +---
 src/mv.c        |   14 +--
 src/system.h    |   24 ++++
 src/unexpand.c  |  107 +++++++++++++----
 11 files changed, 498 insertions(+), 88 deletions(-)

-- 
   Sami Kerola
   http://www.iki.fi/kerolasa/

Attachment: 0001-unexpand-support-in-place-option.txt
Description: Text document


reply via email to

[Prev in Thread] Current Thread [Next in Thread]