coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[coreutils] [PATCH] tests: don't disqualify FreeBSD 8.1's /bin/sh just y


From: Jim Meyering
Subject: [coreutils] [PATCH] tests: don't disqualify FreeBSD 8.1's /bin/sh just yet,
Date: Sun, 07 Nov 2010 21:14:31 +0100

I'll push this tomorrow:

>From dd45755406861fc192284d7e2b28f3c33e0433d3 Mon Sep 17 00:00:00 2001
From: Jim Meyering <address@hidden>
Date: Sun, 7 Nov 2010 14:23:32 +0100
Subject: [PATCH] tests: don't disqualify FreeBSD 8.1's /bin/sh just yet,

because dash-0.5.6-2.fc14.x86_64 would also be disqualified.
This reverts part of yesterday's commit 6c058b2d, "tests: avoid
failure due to bug in FreeBSD 8.1's /bin/sh".  Note that the offending
aspect of those shells is not officially a bug, since "local" is not
specified by POSIX.  However, it is very unintuitive that prepending
"local" to an existing, standards-compliant assignment would evoke
such a fundamental change in semantics.
* tests/init.sh: Remove snippet requiring sane "local" support.
Upstream dash bug report:
http://thread.gmane.org/gmane.comp.shells.dash/419
---
 tests/init.sh |    4 ----
 1 files changed, 0 insertions(+), 4 deletions(-)

diff --git a/tests/init.sh b/tests/init.sh
index 0193cbe..a57de77 100644
--- a/tests/init.sh
+++ b/tests/init.sh
@@ -93,9 +93,6 @@ else
 fi

 # We require $(...) support unconditionally.
-# We also require "local" support.  The local-vs-IFS test is required to
-# eliminate FreeBSD 8.1's /bin/sh, which would otherwise pass these tests
-# and provoke opaque test failures in coreutils.
 # We require a few additional shell features only when $EXEEXT is nonempty,
 # in order to support automatic $EXEEXT emulation:
 # - hyphen-containing alias names
@@ -118,7 +115,6 @@ fi
 #  ? - not ok
 gl_shell_test_script_='
 test $(echo y) = y || exit 1
-gl_local_test_(){ local s=$IFS; test -n "$s"; }; gl_local_test_ || exit 1
 score_=10
 if test "$VERBOSE" = yes; then
   test -n "$( (exec 3>&1; set -x; P=1 true 2>&3) 2> /dev/null)" && score_=9
--
1.7.3.2.193.g78bbb



reply via email to

[Prev in Thread] Current Thread [Next in Thread]