[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Chicken-hackers] [PATCH] Fix #1133

From: Peter Bex
Subject: [Chicken-hackers] [PATCH] Fix #1133
Date: Thu, 19 Jun 2014 20:11:31 +0200
User-agent: Mutt/

Hi all,

Here's a pretty simple patch for #1133.  It segfaults with a regular
build, but a DEBUGBUILD says exactly what's wrong:

Error: unbound variable: make-input-port

        Call history:

        foo.scm:2: tcp-listen     
        foo.scm:2: tcp-accept           <--

The problem got introduced when we fixed a similar bug in unit ports,
This time it turns out that the core itself gets its dependencies wrong:
tcp uses one procedure from ports but none from extras, even though it
only depends on extras!

I've replaced extras by ports to fix the dependency stuff.  I think it's
time we started making a more concrete plan on how to make the core
system use proper modules instead of "units", while still maintaining
separate compilation of course!  If we use modules, this kind of bug
will be easily detected because the module refuses to compile.  It will
also make the system cleaner in general because names won't "leak out"
unless explicitly imported.  Anyway, this is a long-term project that
will probably require fixing #1131 (kill ##sys#alias-global-hook) first.

This bugfix should probably go into the stability branch.


Attachment: 0001-Fix-1133-by-adding-ports-and-dropping-extras-in-unit.patch
Description: Text document

reply via email to

[Prev in Thread] Current Thread [Next in Thread]