Re: [Chicken-hackers] [PATCH 1/4] csi dirseparator?: don't treat backslash as dir separator on non-windows

[Peter Bex]

On Fri, Mar 15, 2013 at 03:48:13PM -0500, Jim Ursetto wrote:
> On Mar 15, 2013, at 3:42 PM, Peter Bex wrote:
> 
> > On Fri, Mar 15, 2013 at 09:29:52PM +0100, Felix wrote:
> >> The current behaviour was probably caused by lazyness. Yes, let's
> >> change it as Florian proposes.
> > 
> > I've already posted a signed off patch of this change.  I'd appreciate if
> > someone could sign off and push this.
> 
> Is it possible to add a test for this?

That would be a little tricky: it only affects a few flags of csi,
not any easily-tested API.

Hmm, I just noticed there's also a chop-separator implementation
in support.scm which is slightly different and seems to be similarly
implemented, which is used by the compiler.  Damn, this all needs to
be cleaned up!  Maybe replace it with one simple ##sys# procedure in
library.scm that the others can call out to.

There are also various other places where a pattern like
(or (char=? #\\ c) (char=? #\/ c)) occurs.  Making a proper patch
would involve some serious hackery.

Cheers,
Peter
-- 
http://www.more-magic.net