[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Chicken-hackers] [PATCH 3/4] Remove ##sys#expand-home-path.
From: |
Mario Domenech Goulart |
Subject: |
Re: [Chicken-hackers] [PATCH 3/4] Remove ##sys#expand-home-path. |
Date: |
Tue, 19 Mar 2013 21:48:52 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.2 (gnu/linux) |
Hi John,
On Tue, 19 Mar 2013 22:01:45 -0400 John Cowan <address@hidden> wrote:
> Mario Domenech Goulart scripsit:
>
>> b. Drop ##sys#expand-home-path. Do not implicitly expand ~ and
>> environment variables in pathnames. Provide a procedure to expand ~
>> in pathnames. That's what this patch implements.
>
> I suggest:
>
> b2. Keep ##sys#expand-home-path, but make it the identity function.
> Provide a procedure to expand ~ in pathnames.
>
> That way, the security problem is removed, but we do not have to find
> and fix every reference to ##sys#expand-home-path.
IMO, in this case we should just remove ##sys#expand-home-path, since it
is an internal procedure. Users should not rely on stability of the
internal API. By keeping ##sys#expand-home-path as an identity
procedure, we'd be just polluting the core and adding a useless
procedure call to every procedure of the filesystem API.
Best wishes.
Mario
--
http://parenteses.org/mario
- Re: [Chicken-hackers] [PATCH 3/4] Remove ##sys#expand-home-path., (continued)
- Re: [Chicken-hackers] [PATCH 3/4] Remove ##sys#expand-home-path., Felix, 2013/03/18
- Re: [Chicken-hackers] [PATCH 3/4] Remove ##sys#expand-home-path., Jim Ursetto, 2013/03/15
- Re: [Chicken-hackers] [PATCH 3/4] Remove ##sys#expand-home-path., Felix, 2013/03/16
- Re: [Chicken-hackers] [PATCH 3/4] Remove ##sys#expand-home-path., Peter Bex, 2013/03/19
- Re: [Chicken-hackers] [PATCH 3/4] Remove ##sys#expand-home-path., John Cowan, 2013/03/19
- Re: [Chicken-hackers] [PATCH 3/4] Remove ##sys#expand-home-path., Mario Domenech Goulart, 2013/03/19
- Re: [Chicken-hackers] [PATCH 3/4] Remove ##sys#expand-home-path., John Cowan, 2013/03/19
- Re: [Chicken-hackers] [PATCH 3/4] Remove ##sys#expand-home-path.,
Mario Domenech Goulart <=
- Re: [Chicken-hackers] [PATCH 3/4] Remove ##sys#expand-home-path., John Cowan, 2013/03/19
- Re: [Chicken-hackers] [PATCH 3/4] Remove ##sys#expand-home-path., Jim Ursetto, 2013/03/19
Re: [Chicken-hackers] [PATCH 3/4] Remove ##sys#expand-home-path., Jim Ursetto, 2013/03/15
Re: [Chicken-hackers] [PATCH 1/4] csi dirseparator?: don't treat backslash as dir separator on non-windows, Christian Kellermann, 2013/03/15
Re: [Chicken-hackers] [PATCH 1/4] csi dirseparator?: don't treat backslash as dir separator on non-windows, Peter Bex, 2013/03/15