bug-xnee
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Bug-xnee] Multiple problems with --retype-file


From: Joseph Miele
Subject: [Bug-xnee] Multiple problems with --retype-file
Date: Sun, 14 Mar 2004 02:49:59 -0500
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4) Gecko/20030624

Version: 1.08

Problem # 1: The --time option is ignored when using option --retype-file. The contents of the file are typed immdiately.

Problem #2: The auto key repeat in X is disabled after running xnee with the --retype-file option.

Possible cause: After reviewing the code, I noticed that file parse.c calls subroutine xnee_type_file, ostensibly to verify that the file to be retyped exists. However, this call to the file does more than simply verify the existence of the file. It actually performs the file retyping during the parsing of the command line arguments! By performing the file retyping from parse.c, the --time argument is ignored, which results in problem #1. In addition, subroutine xnee_type_file does not terminate with a return statement, but with an exit! Since xnee_type_file calls xnee_set_autorepeat, but does NOT call xnee_reset_autorepeat, the auto key repeat in X is disabled and never reset! This results in problem #2.

Possible solution: File parse.c needs to be changed so it doesn't call subroutine xnee_file_type to verify if the file to be retyped exists. It needs to store the file name in structure xnee_data, so subroutine xnee_type_file can reference it later. Then subroutine xnee_type_file needs to be changed so it does not call xnee_set_autorepeat and so it does not terminate with an exit, but with a return. This will allow it to function like other subroutines so options such as --time will be processed.

I can make these changes, but I am hesitant to do so. Before doing anything, I thought I would submit these problems (and my ideas for a solution) here first. After all, you know this code better than I do. :-)







reply via email to

[Prev in Thread] Current Thread [Next in Thread]