Re: [bug-sourceinstall] --prefix option not retained

[Claudio Fontana]

Nicola Fontana wrote:
> On Wed, 25 Jun 2008 19:45:46 +0200
> Claudio Fontana <address@hidden> wrote:
>
> > > I didn't search a lot to find such package... gtk+ itsself
> > > suffers this problem with the --with-xinput and --with-x
> > > options.
> > >
> > > I recompiled enabling both of them:
> > >
> > > ./configure --enable-static=no --enable-shared
> > > --disable-largefile --enable-debug=no --with-gnu-ld
> > > --with-xinput --with-x --libdir=/usr/lib64 --prefix=/usr
> > >
> > > and yes, when upgrading the --with-x option is lost.
> > We need to fix this, and we need to change that code anyway
> > if we want to prioritize the --prefix option in old_configured,
> > as the assumption that every option is followed by space or '='
> > does not hold anymore. I'll just use a regex, I have no
> > idea why I haven't before.
>
> I also suggest you to single quote every value, if applicable.
> Dealing with spaces in option values can be a nightmare.
>
> Ciao

The real nightmare is the fact that while the key _should_
consist only of [[:alnum:]_-], the user can force dangerous
characters into the regex by altering the configured_as
package information, or simply using the cmdline tool.
Now I understand why I didn't run a regex before :)