Re: [bug-sourceinstall] --prefix option not retained

[Claudio Fontana]

Nicola Fontana wrote:
> On Wed, 25 Jun 2008 18:36:12 +0200
> "Claudio Fontana" <address@hidden> wrote:
>
> > > > > While writing it I noticed something weird on the parser that
> > > > > gets the old values.  There is a single strstr() that searches
> > > > > for the option name: what about if I have two arguments such as
> > > > > --with-x-include and --with-x? Will be the --with-x old value
> > > > > ignored in this case?
> > > > It should work correctly, see the code that follows the strstr.
> > > I'm referring also to the following condition:
> > >
> > > start[len] == ' ' || start[len] == '='
> > >
> > > If looking for the "--with-x" key while old_configured contains
> > > "--with-x-include=... --with-x=..." (just an example), strstr()
> > > returns the first match and the condition fails: --with-x=...
> > > will be not checked at all.
> > >
> > > But maybe I'm missing something or this case is yet managed
> > > while building the configure string.
> > I think you are right, although I do not remember anymore
> > what I thought when I wrote that code, as a lot of time has
> > passed. Can you reproduce such a bug?
>
> I didn't search a lot to find such package... gtk+ itsself
> suffers this problem with the --with-xinput and --with-x
> options.
>
> I recompiled enabling both of them:
>
> ./configure --enable-static=no --enable-shared
> --disable-largefile --enable-debug=no --with-gnu-ld
> --with-xinput --with-x --libdir=/usr/lib64 --prefix=/usr
>
> and yes, when upgrading the --with-x option is lost.

We need to fix this, and we need to change that code anyway
if we want to prioritize the --prefix option in old_configured,
as the assumption that every option is followed by space or '='
does not hold anymore. I'll just use a regex, I have no
idea why I haven't before.

Thanks again,

Claudio