Re: [PATCH 1/5] Stylistic fixes

[Samuel Thibault]

Marin Ramesa, le Tue 26 Nov 2013 21:03:31 +0100, a écrit :
> After the patch is applied, fixes for the patch need to be applied (I 
> will send those shortly after this mail). It seems that ANSI style 
> definitions don't allow for forward declarations that conflict the 
> definitions, so these (the declarations) need to be fixed, otherwise 
> there is a compilation error from GCC.

So the patchset needs to be reworked: a git commit is supposed to leave
the tree buildable.

> This patch also introduces several new warnings from GCC. The problem 
> is with functions that are used in structs as ops. Previously they had 
> conflicting forward declarations that satisfied the struct definition, 
> but with the ANSI style definition they produce GCC warnings. If this 
> patch gets applied, I will fix those new warnings.

That's actually a good thing :)

Samuel