[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 1/5] Stylistic fixes
From: |
Marin Ramesa |
Subject: |
[PATCH 1/5] Stylistic fixes |
Date: |
Tue, 26 Nov 2013 21:03:31 +0100 |
Hello,
This patch is a big mixup of sometimes unrelated changes. I originaly
went for a patch that would convert all K&R style function definitions
to ANSI style function definitions, but I got sidetracked into doing
other changes which I didn't know how to put into separate git commits.
The result is this. I hope Samuel can easily pick from this the changes
he thinks are good.
This patch includes:
1. Normalization and addition of whitespace where needed
2. Conversion from K&R style definitions to ANSI style definitions
3. Declaration of void argument lists
4. Alignment of argument lists to TAB character
5. Addition of comments after endifs
6. Removal of MACH_TTD code
7. Removal of i386/i386/kttd_interface.c
8. Removal of i386/i386/time_stamp.h
9. Removal of i386/include/mach/i386/rpc.h
10. Definition of argument types where needed
11. Fixes for argument lists where needed
12. Addition of ifndefs
13. Removal of (#if 1)
14. Definition of return types where needed
15. Removal of an unused function
16. Removal of multimax code
After the patch is applied, fixes for the patch need to be applied (I
will send those shortly after this mail). It seems that ANSI style
definitions don't allow for forward declarations that conflict the
definitions, so these (the declarations) need to be fixed, otherwise
there is a compilation error from GCC.
This patch also introduces several new warnings from GCC. The problem
is with functions that are used in structs as ops. Previously they had
conflicting forward declarations that satisfied the struct definition,
but with the ANSI style definition they produce GCC warnings. If this
patch gets applied, I will fix those new warnings.
stylistic_fixes.tar.gz
Description: application/compressed-tar
- [PATCH 1/5] Stylistic fixes,
Marin Ramesa <=