[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] procfs: another fix for the process file name in stat/status
From: |
Samuel Thibault |
Subject: |
Re: [PATCH] procfs: another fix for the process file name in stat/status |
Date: |
Mon, 10 Sep 2012 20:01:23 +0200 |
User-agent: |
Mutt/1.5.21+34 (58baf7c9f32f) (2010-12-30) |
Pino Toscano, le Mon 10 Sep 2012 18:16:44 +0200, a écrit :
> Alle lunedì 10 settembre 2012, Samuel Thibault ha scritto:
> > Pino Toscano, le Mon 10 Sep 2012 17:31:32 +0200, a écrit :
> > > Alle domenica 9 settembre 2012, Samuel Thibault ha scritto:
> > > > Pino Toscano, le Fri 07 Sep 2012 20:02:56 +0200, a écrit :
> > > > > +static int args_filename_length (const char *name)
> > > > > +{
> > > > > + const char *p = name;
> > > > > + while (*p != '\0' && *p != ' ')
> > > > > + ++p;
> > > >
> > > > Why not using index(name, ' ') here?
> > >
> > > If I would use strchr, the code would be something like:
> > > const char *p = strchr (name, ' ');
> > > return p != NULL ? p - name : strlen (name);
> > >
> > > which, for the common case, would mean scanning the string twice.
> >
> > Ah, right. You can use strchrnul instead.
>
> Indeed -- I didn't know it, thanks for the hint.
Rather thank Guillem, I didn't know it either before he mentioned in
this thread :)
Samuel