bug-hurd
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] procfs: another fix for the process file name in stat/status


From: Samuel Thibault
Subject: Re: [PATCH] procfs: another fix for the process file name in stat/status
Date: Sun, 9 Sep 2012 01:30:30 +0200
User-agent: Mutt/1.5.21+34 (58baf7c9f32f) (2010-12-30)

Guillem Jover, le Sun 09 Sep 2012 01:22:43 +0200, a écrit :
> On Sun, 2012-09-09 at 00:22:11 +0200, Samuel Thibault wrote:
> > Pino Toscano, le Fri 07 Sep 2012 20:02:56 +0200, a écrit :
> > > +static int args_filename_length (const char *name)
> > > +{
> > > +  const char *p = name;
> > > +  while (*p != '\0' && *p != ' ')
> > > +    ++p;
> > 
> > Why not using index(name, ' ') here?
> 
> index() is deprecated

Right. strchr then, I don't care the detail, I just care about not
reimplementing it :)

> and it needs the NULL case handled, like strchr()
> but not like strchrnul(),

Not really a problem.

> but better to use strcspn() anyway.

Why? It's not currently optimized for the 1-character case, and will
probably not be.

Samuel



reply via email to

[Prev in Thread] Current Thread [Next in Thread]