bug-grep
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 8/9] grep: prepare for libification of *search.c


From: Jim Meyering
Subject: Re: [PATCH 8/9] grep: prepare for libification of *search.c
Date: Fri, 19 Mar 2010 16:33:18 +0100

Paolo Bonzini wrote:
> * src/dfasearch.c (Ecompile): Remove.
> * src/esearch.c: Place it here...
> * src/gsearch.c: ... and here.

We never like duplication, but it's a tiny function...
ACK

...
> diff --git a/src/esearch.c b/src/esearch.c
...
> +static void
> +Ecompile (char const *pattern, size_t size)
> +{
> +  return GEAcompile (pattern, size, RE_SYNTAX_POSIX_EGREP);
> +}

> diff --git a/src/gsearch.c b/src/gsearch.c
...
> +static void
> +Ecompile (char const *pattern, size_t size)
> +{
> +  return GEAcompile (pattern, size, RE_SYNTAX_POSIX_EGREP);
> +}




reply via email to

[Prev in Thread] Current Thread [Next in Thread]