Re: [PATCH 0/9] remove most {,E,F}GREP_PROGRAM occurrences

[Jim Meyering]

Paolo Bonzini wrote:
> This patchset removes all occurrences of {,E,F}GREP_PROGRAM outside grep.c.
> #ifdefs are avoided by splitting search.c into multiple files and letting
> the linker drop those that are not used.  I tested that there is basically
> no change in executable size for any of {,e,f}grep.
>
> I have one that removes the remaining occurrences, but it introduces new
> strings so it would require another snapshot before submitting the .POT
> file to the translation project.

2nd step was to run "make syntax-check".
It spotted two nits:

    src/gsearch.c
    maint.mk: the above files do not include <config.h>
    make: *** [sc_require_config_h] Error 1
    src/gsearch.c
    maint.mk: the above files include some other header before <config.h>
    make: *** [sc_require_config_h_first] Error 1
    --- po/POTFILES.in
    +++ po/POTFILES.in
    @@ -9,6 +9,5 @@
     src/dfa.c
     src/dfasearch.c
     src/grep.c
    -src/kwsearch.c
     src/kwset.c
     src/pcresearch.c
    maint.mk: you have changed the set of files with translatable diagnostics;
     apply the above patch
    make: *** [sc_po_check] Error 1