Re: [bug-grep] Boyer Moore overflow patch

[Paul Eggert]

Julian Foad <address@hidden> writes:

> +      Moo that's not _that_ easy; you have to avoid an overflow. */

"Moo"?

>        for (i = 0; i < kwset->mind; ++i)
> -     delta[(unsigned char) kwset->target[i]] = kwset->mind - (i + 1);
> +     delta[(unsigned char) kwset->target[i]] =
> +       MIN(kwset->mind - (i + 1), UCHAR_MAX);

There should be a space after the "MIN".  (This is the style
recommended by the GNU coding standards.)