Re: Applying outstanding patches [bug-grep]

[Tim Waugh]

On Thu, Apr 14, 2005 at 06:47:50PM +0100, Julian Foad wrote:

> > I seem to remember that some of
> >them are tweaked in various small ways.
> 
> Eww.  That's a recipe for breakage later.

I might be wrong about it -- I really don't remember actually.

> I have gone through your patches as logged in the Grep Savannah
> issue tracker, and tried to add pointers to the original bug reports
> in the Red Hat tracker, because there are usually explanations of
> the bug and reproduction recipes there.  It's difficult to use a
> source code patch when the scope and details of the problem it
> addresses are not specified.  If you could go through and add
> descriptions and pointers to reports to the rest of them, that would
> be great.

I saw that you had done that, and assumed that you had copied in my
links from when I sent all the information I had to this mailing list
(or its previous incarnation) last year.

> Sure, but maybe you can help us with testing.  For instance, did you use 
> any automated test scripts?

Actually I didn't, but I did perform some ad-hoc tests for the error
conditions: for example, the behaviour when given invalid UTF-8
shouldn't change before/after the egf-speedup patch, since it does not
address any correctness issues only performance.

Tim.
*/

pgp48XCK_3hyf.pgp
Description: PGP signature