|
| From: | Paolo Bonzini |
| Subject: | Re: MS-Windows build of Grep [2/4] |
| Date: | Wed, 28 Dec 2011 14:20:44 +0100 |
| User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:7.0.1) Gecko/20110930 Thunderbird/7.0.1 |
On 12/24/2011 01:59 PM, Eli Zaretskii wrote:
+ return + isatty (fd) +#ifdef __MINGW32__ + /* Without the lseek call, Windows isatty returns non-zero for the + null device as well. */ +&& lseek (fd, SEEK_CUR, 0) == -1 +#endif
This fix to isatty should be done in gnulib. Otherwise the patch looks good. Refactoring can be done later. Paolo
| [Prev in Thread] | Current Thread | [Next in Thread] |