[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] bzr-version-gen: New module.
From: |
Bruno Haible |
Subject: |
Re: [PATCH] bzr-version-gen: New module. |
Date: |
Sat, 6 Aug 2011 14:41:56 +0200 |
User-agent: |
KMail/1.13.6 (Linux/2.6.37.6-0.5-desktop; KDE/4.6.0; x86_64; ; ) |
Hello Giuseppe,
> I would like to contribute this new module. I am using it for wget, it
> works like git-version-gen, except it supports Bazaar.
The git-version-gen script has a lot more comments and better error checking.
Surely you don't want to duplicate this code? How about, then, merging your
script with git-version-gen, and rename the module to 'vc-version-gen'?
(The prefix 'vc' would be consistent with vc-dwim and vc-changelog.)
> +test -n "$(bzr diff | tr -d '\n')" && DIRTY="-dirty"
The use of $(...) is not portable. Use `...` for portability.
For more on shell code portability, see the Autoconf manual
<http://www.gnu.org/software/autoconf/manual/html_node/Portable-Shell.html>
in particular
<http://www.gnu.org/software/autoconf/manual/html_node/Shell-Substitutions.html>
Bruno
--
In memoriam Janusz Korczak <http://en.wikipedia.org/wiki/Janusz_Korczak>