[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Question about critical_factorization() in the Two-Way algorithm
From: |
Bruno Haible |
Subject: |
Re: Question about critical_factorization() in the Two-Way algorithm |
Date: |
Sat, 18 Dec 2010 14:58:58 +0100 |
User-agent: |
KMail/1.9.9 |
Hello Pádraig,
> I've rebased the attached memmem reorg patch
> which splits correctness checks from performance checks.
How about a couple of stylistic changes: use GNU style whitespace placement,
'const char *' not 'char *' for string literals, and NULL not 0 for the null
pointer, preprocessor command indentation, and an improved comment.
OK to commit?
2010-12-18 Bruno Haible <address@hidden>
memmem-simple: Stylistic changes.
* m4/memmem.m4 (gl_FUNC_MEMMEM_SIMPLE): Avoid possible gcc warning.
Fix preprocessor indentation.
--- m4/memmem.m4.orig Sat Dec 18 14:58:21 2010
+++ m4/memmem.m4 Sat Dec 18 14:58:15 2010
@@ -1,4 +1,4 @@
-# memmem.m4 serial 21
+# memmem.m4 serial 22
dnl Copyright (C) 2002, 2003, 2004, 2007, 2008, 2009, 2010 Free Software
dnl Foundation, Inc.
dnl This file is free software; the Free Software Foundation
@@ -32,16 +32,16 @@
result |= 1;
/* Check for empty needle behavior. */
{
- char* haystack="AAA";
- if (memmem (haystack, 3, 0, 0) != haystack)
+ const char *haystack = "AAA";
+ if (memmem (haystack, 3, NULL, 0) != haystack)
result |= 2;
}
return result;
]])],
[gl_cv_func_memmem_works_always=yes],
[gl_cv_func_memmem_works_always=no],
- [dnl glibc 2.12 and cygwin 1.7.7 have issue #12092 above.
- dnl Also empty needles work on glibc >= 2.1 and cygwin >= 1.7.0
+ [dnl glibc 2.9..2.12 and cygwin 1.7.7 have issue #12092 above.
+ dnl Also empty needles work on glibc >= 2.1 and cygwin >= 1.7.0.
dnl uClibc is not affected, since it uses different source code.
dnl Assume that it works on all other platforms (even if not linear).
AC_EGREP_CPP([Lucky user],
@@ -50,7 +50,8 @@
#include <features.h>
#if ((__GLIBC__ == 2 && ((__GLIBC_MINOR > 0 && __GLIBC_MINOR__ < 9) \
|| __GLIBC_MINOR__ > 12)) \
- || (__GLIBC__ > 2)) || defined __UCLIBC__
+ || (__GLIBC__ > 2)) \
+ || defined __UCLIBC__
Lucky user
#endif
#elif defined __CYGWIN__