Re: [Bug-gnubg] Multiprocessing

[Nardy Pillards]

From: "Olivier Baur" <address@hidden>
Sent: Tuesday, July 08, 2003 4:11 PM


> > Compiling dice.c, error:
> > In file included from dice.c:80:
> > gtkgame.h:80: parse error before numeric constant
> > gtkgame.h:80: conflicting types for `CreateDialogParamA'
> > C:/MINGW/include/winuser.h:2756: previous declaration of
> > `CreateDialogParamA'
> > C:\MINGW\BIN\MINGW3~4.EXE: *** [dice.o] Error 1
> >
> > possible reason:
> > windows.h calls winuser.h
> > winuser.h uses same CreateDialog definition as GTK does???
> 
> Some ideas:
> The problem does seem to come from incompatible definitions of 
> CreateDialog, in both gtkgame.h and windows.h.

yes
 
> How come it did compile before adding multiprocessing support, ie 
> before adding pthreads and sockets? Something must have changed in the 
> way you're compiling/linking? Was windows.h included in previous 
> compiles of dice.c? Where does windows.h get included from? 
> winsocket.h? Maybe you can include gtkgame.h before 
> winsocket.h/windows.h and tweak windows.h so it doesn't declare 
> CreateDialog() if _GTKGAME_H_ is already defined? Or maybe we should 
> rename gnubg's CreateDialog() to something like GTK_CreateDialog()?

no multiprocessing support before.

windows.h included because WIN32 is defined (if WIN32 / include windows.h)

yes, putting 'include gtkgame.h' just after 'config.h': no more error

tweak windows.h: included in MinGW, don't like tweaking that

rename.... yes. i think that should be done

> 
> Does the problem appear only in dice.c? Or does it also show up in 
> other .c files?

others also (e.g. gtkgame.c) and no use moving 'include gtkgame.h' there

> 
> Maybe I should try to merge the current gnubg version into the multi 
> branch...?
> 

Nardy