bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#35624: log-view-diff regression


From: Juri Linkov
Subject: bug#35624: log-view-diff regression
Date: Fri, 24 May 2019 21:41:59 +0300
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu)

>> -    (insert "\n")
>> +        (overlay-put (make-overlay (point) (progn (insert (propertize "\n" 
>> 'help-echo
>> +          "You can use `d' on the top empty line to compare with the 
>> current working revision"))
>> +          (point)))
>> +          'invisible t)
>
> Is this a tested patch? It doesn't seem to work over here. 'C-p'
> does nothing.

It's just a sketch, it doesn't work when trying.  This shows that
due to reveal-mode's glitches, this solution can't be used here.

> BTW, why help-echo? We have an otherwise unoccupied line, might as well
> show the text there directly.
>
> What do you think about this version, though:
>
>   (Press 'd' here to see the diff against the current working revision)
>
> ?

Ok, will show this text dimmed.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]