bug#35624: log-view-diff regression

[Dmitry Gutov]

On 24.05.2019 0:07, Juri Linkov wrote:
> -       (insert "\n")
> +        (overlay-put (make-overlay (point) (progn (insert (propertize "\n" 
> 'help-echo
> +          "You can use `d' on the top empty line to compare with the current 
> working revision"))
> +          (point)))
> +          'invisible t)

Is this a tested patch? It doesn't seem to work over here. 'C-p' does 
nothing.

BTW, why help-echo? We have an otherwise unoccupied line, might as well 
show the text there directly.

What do you think about this version, though:

  (Press 'd' here to see the diff against the current working revision)

?

I don't mind the words "compare with", but they seem to elicit the 
question, "compare what?" The empty line?