|
From: | Stefan Monnier |
Subject: | bug#11095: [PATCH] Re: bug#11095: 24.0.94; hi-lock-face-buffer/unhighlight-regexp': Augment? |
Date: | Thu, 06 Dec 2012 14:16:57 -0500 |
User-agent: | Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) |
> (get-char-property (point) 'face) > : "hi-yellow" I just fixed that a little while ago. > Issue-2: Various issues with unhighlighting > ============================================ > Once you fix Issue-1 you will run in to other issues with > un-highlighting. Try highlighting and UN-highlighting in following 3 > ways > 1. Buffer with font-lock-mode ON > 2. Buffer with font-lock-mode OFF > 3. Unhighlight from the menu Seems to be working now (haven't tried before my recent changes, tho). > (defcustom hi-lock-face-defaults > '(hi-yellow hi-pink hi-green hi-blue hi-black-b > hi-blue-b hi-red-b hi-green-b hi-black-hb) > "Default faces for hi-lock interactive functions." > :type '(repeat face) > :group 'hi-lock-faces) I think it'd be important to make it possible/easy for the user to add new faces of his own creation in there. So we'd need a :setter that creates those faces as needed. BTW, I wouldn't spend too much time on hi-lock-auto-select-face since setting it to t just saves you from typing RET RET instead of RET. I'm not even sure we want to keep such configuration. Stefan
[Prev in Thread] | Current Thread | [Next in Thread] |