|
From: | Aharon Robbins |
Subject: | Re: [bug-gawk] [PATCH] gawk 4.1.1 replace "/inet" with preprocessor macro |
Date: | Sun, 20 Apr 2014 12:15:54 +0300 |
User-agent: | Heirloom mailx 12.5 6/20/10 |
Hi Andy. This patch looks pretty good. Please change "nul-terminated" in the comment to either "NUL-terminated" or "zero-terminated" and then I think it's good to go. After the explanation, I'm fine with using offsets; you may wish to add a comment somewhere that using offsets avoids problems with "char *" vs. "const char *" mismatches and compiler warnings. Please commit to gawk-4.1-stable and then merge to master. You should do a git pull before starting. :-) Much thanks for handling this. Arnold
[Prev in Thread] | Current Thread | [Next in Thread] |